Feature: SVG optimization #1350
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Use copy=False flag when calling add_item in svg.build_group
|
I'm sure there are other parts of the SVG handling that can help, but this seemed to be the low hanging fruit. In my case it dropped ~100 page PDF generation from 27 minutes to 13... |
|
@allcontributors please add @petri-lipponen-movesense for code |
|
I've put up a pull request to add @petri-lipponen-movesense! 🎉 |
Lucas-C
reviewed
Jan 17, 2025
|
Wow, thank you very much @petri-lipponen-movesense! 👍 Excellent job, thank you very much for this contribution ❤️ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist:
A unit test is covering the code added / modified by this PR. N/A
This PR is ready to be merged
In case of a new feature, docstrings have been added, with also some documentation in the
docs/folder N/AA mention of the change is present in
CHANGELOG.mdBy submitting this pull request, I confirm that my contribution is made under the terms of the GNU LGPL 3.0 license.